Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait
Date: 2011-08-02 19:23:15
Message-ID: 27843.1312312995@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On Tue, Aug 2, 2011 at 6:24 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Fix incorrect initialization of ProcGlobal->startupBufferPinWaitBufId.
>>
>> It was initialized in the wrong place and to the wrong value. With bad
>> luck this could result in incorrect query-cancellation failures in hot
>> standby sessions, should a HS backend be holding pin on buffer number 1
>> while trying to acquire a lock.

> Did I miss a bug report?

No, this was something I happened across in code-reading a few weeks ago
and had a note to myself to fix. While looking at it today I found more
problems ... see second commit.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2011-08-02 20:13:56 Re: pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait
Previous Message Tom Lane 2011-08-02 19:17:13 pgsql: Move CheckRecoveryConflictDeadlock() call to a safer place.