Re: recovering from "found xmin ... from before relfrozenxid ..."

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: recovering from "found xmin ... from before relfrozenxid ..."
Date: 2020-07-14 01:26:38
Message-ID: 2783971.1594689998@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jul 13, 2020 at 8:58 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The more that I think about it, the more I think that the proposed
>> functions are tools for wizards only, and so I'm getting hesitant
>> about having them in contrib at all. We lack a better place to
>> put them, but that doesn't mean they should be there.

> I understand that it's not too great when we give people access to
> sharp tools and they hurt themselves with said tools. But this is open
> source. That's how it goes.

I think you're attacking a straw man. I'm well aware of how open source
works, thanks. What I'm saying is that contrib is mostly seen to be
reasonably harmless stuff. Sure, you can overwrite data you didn't want
to with adminpack's pg_file_write. But that's the price of having such a
capability at all, and in general it's not hard for users to understand
both the uses and risks of that function. That statement does not apply
to the functions being proposed here. It doesn't seem like they could
possibly be safe to use without very specific expert advice --- and even
then, we're talking rather small values of "safe". So I wish we had some
other way to distribute them than via contrib.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-07-14 01:29:10 Re: recovering from "found xmin ... from before relfrozenxid ..."
Previous Message Robert Haas 2020-07-14 01:18:10 Re: recovering from "found xmin ... from before relfrozenxid ..."