| From: | torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Alexander Kukushkin <cyberdemn(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org, bungina(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_rewind WAL segments deletion pitfall |
| Date: | 2023-11-09 06:30:56 |
| Message-ID: | 277e2f594a4e64d330fb770debc6a02e@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2023-11-06 23:58, Alexander Kukushkin wrote:
> Hi Torikoshia,
>
> On Thu, 2 Nov 2023 at 04:24, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
> wrote:
>
>>> +extern void preserve_file(char *filepath);
>>
>> Is this necessary?
>> This function was defined in older version patch, but no longer
>> seems to
>> exist.
>>
>> +# We use "perl -e 'exit(1)'" as a alternative to "false", because
>> the
>> last one
>> 'a' should be 'an'?
>
> Thanks for the feedback
>
> Please find the new version attached.
Thanks for the update!
I've set the CF entry to "Ready for Committer".
--
Regards,
--
Atsushi Torikoshi
NTT DATA Group Corporation
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-11-09 11:08:38 | Re: BUG #18187: Unexpected error: "variable not found in subplan target lists" triggered by JOIN |
| Previous Message | Andrei Lepikhov | 2023-11-09 04:51:14 | Re: BUG #18187: Unexpected error: "variable not found in subplan target lists" triggered by JOIN |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-11-09 06:30:59 | Re: A recent message added to pg_upgade |
| Previous Message | Amit Kapila | 2023-11-09 06:18:19 | Re: pg_upgrade and logical replication |