| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tristan Partin <tristan(at)neon(dot)tech>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Meson build updates |
| Date: | 2023-06-12 21:24:26 |
| Message-ID: | 277c356e-7ef7-4c87-f4b2-97a13914dd02@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12.06.23 20:48, Tristan Partin wrote:
> Attached you will find a v3 with the offending commits removed. I did
> leave the overrides in since you didn't mention it in your last email.
Patches 1-14 look ok to me. (But I didn't test anything, so some
caveats about whether the non-cosmetic patches actually work apply.) If
we're fine-tuning the capitalization the options descriptions, let's
also turn "tap tests" into "TAP tests" and "TCL" into "Tcl".
Patch 15 about the wrap integration, I'm not sure. I share the concerns
about whether this is worth maintaining. Maybe put this patch into the
commitfest separately, to allow for further study and testing. (The
other patches, if they are acceptable, ought to go into PG16, I think.)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomasz Rybak | 2023-06-12 21:27:04 | Re: index prefetching |
| Previous Message | Heikki Linnakangas | 2023-06-12 21:17:15 | Re: Let's make PostgreSQL multi-threaded |