Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> Since the introduction of the CATALOG_VARLEN stuff, the fixed size of
> pg_attribute is exactly sizeof(FormData_pg_attribute), so the ancient
> mechanism to track the fixed size manually using
> ATTRIBUTE_FIXED_PART_SIZE can be removed.
Meh, I'm not sure about this. What about the possibility of trailing
padding after the last fixed column, as the comment you propose to
remove is talking about? Sure, we don't have that today, but we
might again the next time somebody adds a column to pg_attribute.
regards, tom lane