| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Beattie <mtbeedee(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FATAL: bogus data in lock file "postmaster.pid": "" |
| Date: | 2012-08-29 04:56:26 |
| Message-ID: | 27691.1346216186@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Wed, Aug 29, 2012 at 12:24:26AM -0400, Alvaro Herrera wrote:
>> It's a pretty strange line wrap you got in this version of the patch.
>> Normally we just let the string run past the 78 char limit, without
>> cutting it in any way. And moving the start of the string to the line
>> following "errhint(" looks very odd to me.
> OK, updated patch attached.
I agree with Alvaro's complaint that moving the whole string literal to
the next line isn't conformant to our usual coding style. Definitely
nitpicky, but why would you do it like that?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Benedikt Grundmann | 2012-08-29 06:59:10 | Re: MySQL search query is not executing in Postgres DB |
| Previous Message | Amit kapila | 2012-08-29 04:53:10 | Re: [WIP] Performance Improvement by reducing WAL for Update Operation |