Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Subject: Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice
Date: 2007-09-27 14:08:32
Message-ID: 27596.1190902112@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> That's not fixing the problem, unless your proposal includes never
>> issuing any warnings at all, for anything.

> No warning for "*" because it is intentional, but warning for actual
> stop words.

No, you're focusing on one symptom not the problem. The problem is
that we've got user-visible behavior going on during what's effectively
a chance event, ie, a cache reload.

One possible real solution would be to tweak the dictionary APIs so
that the dictionaries can find out whether this is the first load during
a session, or a reload, and emit notices only in the first case.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-09-27 17:42:03 pgsql: Fix Assert failure in ExpandColumnRefStar --- what I thought was
Previous Message Tom Lane 2007-09-27 13:52:04 Re: pgsql: Some small tuptoaster improvements from Greg Stark.

Browse pgsql-hackers by date

  From Date Subject
Next Message NikhilS 2007-09-27 14:12:06 Assertion failure due to ColumnRefStar
Previous Message Tom Lane 2007-09-27 13:48:54 Re: Text <-> C string

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-27 18:36:41 Re: Warning is adjusted of pgbench.
Previous Message Tom Lane 2007-09-27 13:48:54 Re: Text <-> C string