Re: KOI8-U support (was Re: [BUGS] create database warning)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Mykola Stryebkov <mykola(dot)stryebkov(at)gmail(dot)com>
Subject: Re: KOI8-U support (was Re: [BUGS] create database warning)
Date: 2009-02-06 21:40:00
Message-ID: 27578.1233956400@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

> diff -Nur ../cvs-pgsql/src/backend/utils/mb/wchar.c ./src/backend/utils/mb/wchar.c
> --- ../cvs-pgsql/src/backend/utils/mb/wchar.c 2009-01-30 10:35:27.000000000 +0200
> +++ ./src/backend/utils/mb/wchar.c 2009-02-06 18:19:48.000000000 +0200
> @@ -1373,6 +1373,7 @@
> {pg_latin12wchar_with_len, pg_latin1_mblen, pg_latin1_dsplen, pg_latin1_verifier, 1}, /* 31; PG_WIN1254 */
> {pg_latin12wchar_with_len, pg_latin1_mblen, pg_latin1_dsplen, pg_latin1_verifier, 1}, /* 32; PG_WIN1255 */
> {pg_latin12wchar_with_len, pg_latin1_mblen, pg_latin1_dsplen, pg_latin1_verifier, 1}, /* 33; PG_WIN1257 */
> + {pg_latin12wchar_with_len, pg_latin1_mblen, pg_latin1_dsplen, pg_latin1_verifier, 1}, /* 34; PG_KOI8U */
> {0, pg_sjis_mblen, pg_sjis_dsplen, pg_sjis_verifier, 2}, /* 34; PG_SJIS */
> {0, pg_big5_mblen, pg_big5_dsplen, pg_big5_verifier, 2}, /* 35; PG_BIG5 */
> {0, pg_gbk_mblen, pg_gbk_dsplen, pg_gbk_verifier, 2}, /* 36; PG_GBK */

I'm not convinced that putting the encoding numbers in these comments
is useful; if it is you need to update them. Or we could just remove
them.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Iceman 2009-02-07 23:49:58 BUG #4644: Urgent
Previous Message Peter Eisentraut 2009-02-06 17:37:45 KOI8-U support (was Re: [BUGS] create database warning)

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2009-02-06 22:08:39 Re: Review: B-Tree emulation for GIN
Previous Message Tom Lane 2009-02-06 21:16:10 Re: Column-Level Privileges