Re: jsonpath

Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> writes:
> Attached patchset contains revised commit messages. I'm going to
> commit this on no objections.

Sorry for slow response --- I was tied up with release preparations.

The -5 patches look pretty good. A couple of nits:

@@ -774,9 +749,7 @@ executeItemOptUnwrapTarget(JsonPathExecContext *cxt, JsonPathItem *jsp,
{
RETURN_ERROR(ereport(ERROR,
(errcode(ERRCODE_JSON_ARRAY_NOT_FOUND),
- errmsg(ERRMSG_JSON_ARRAY_NOT_FOUND),
- errdetail("jsonpath array accessor can "
- "only be applied to an array"))));
+ errdetail("jsonpath array accessor can only be applied to an array"))));
}
break;

I think you forgot to s/errdetail/errmsg/ in this one. Likewise at:

+ errdetail("jsonpath wildcard member accessor can only be applied to an object"))));

Also, I saw two places where you missed removing a trailing period
from an errmsg:

+ errmsg("left operand of jsonpath operator %s is not a single numeric value.",
+ jspOperationName(jsp->type)))));

+ errmsg("right operand of jsonpath operator %s is not a single numeric value.",
+ jspOperationName(jsp->type)))));

I'd suggest making a quick pass for other instances of the same mistakes,
just in case. I'm good with the wording on everything now.

regards, tom lane