| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Ali Akbar <the(dot)apaan(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Dmitry Vasilyev <d(dot)vasilyev(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Postgres service stops when I kill client backend on Windows |
| Date: | 2015-10-12 20:35:01 |
| Message-ID: | 27520.1444682101@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> This is kind of a mess :-(. But it does look like what we want is
> for SubPostmasterMain to do more than nothing when it chooses not to
> reattach. Probably that should include resetting UsedShmemSegAddr to
> NULL, as well as closing the handle.
After poking around a bit more, I propose the attached patch. I've
checked that this is happy with an EXEC_BACKEND Unix build, but I'm not
able to test it on Windows ... would somebody do that?
BTW, it appears from this that Cygwin builds have been broken right along
in a different way: according to the code in sysv_shmem's
PGSharedMemoryReAttach, Cygwin does cause a re-attach to occur, which we
were not undoing for putatively-not-connected-to-shmem child processes.
That's a robustness problem because it breaks the postmaster's expectation
that it's safe to not reinitialize shmem after a crash of one of those
processes. I believe this patch fixes that problem as well, though if
anyone can test it on Cygwin that wouldn't be a bad thing either.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| windows-shmem-detach-fix.patch | text/x-diff | 7.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Vasilyev | 2015-10-12 21:24:51 | Re: Postgres service stops when I kill client backend on Windows |
| Previous Message | Stefan Keller | 2015-10-12 20:28:39 | Re: point_ops for GiST |