| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Joel Jacobson" <joel(at)compiler(dot)org> |
| Cc: | "Matheus Alcantara" <matheusssilv97(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimize LISTEN/NOTIFY |
| Date: | 2025-10-08 18:46:16 |
| Message-ID: | 2749343.1759949176@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Joel Jacobson" <joel(at)compiler(dot)org> writes:
> On Tue, Oct 7, 2025, at 22:15, Tom Lane wrote:
>> 5. ChannelHashAddListener: "already registered" case is not reached,
>> which surprises me a bit, and neither is the "grow the array" stanza.
> I've added a test for the "grow the array" stanza.
> The "already registered" case seems impossible to reach, since the
> caller, Exec_ListenCommit, returns early if IsListeningOn.
Maybe we should remove the check for "already registered" then,
or reduce it to an Assert? Seems pointless to check twice.
Or thinking a little bigger: why are we maintaining the set of
channels-listened-to both as a list and a hash? Could we remove
the list form?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2025-10-08 18:48:03 | Re: [PATCH] Add tests for Bitmapset |
| Previous Message | Masahiko Sawada | 2025-10-08 18:45:40 | Re: Invalid pointer access in logical decoding after error |