Re: [PATCH] Add TOAST support for several system tables

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Add TOAST support for several system tables
Date: 2022-02-28 23:08:48
Message-ID: 2748770.1646089728@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?UTF-8?B?U29maWEgS29waWtvdmE=?= <s(dot)kopikova(at)postgrespro(dot)ru> writes:
> ACL lists in tables may potentially be large in size. I suggest adding TOAST support for system tables, namely pg_class, pg_attribute and pg_largeobject_metadata, for they include ACL columns.

TBH, the idea of adding a toast table to pg_class scares the daylights
out of me. I do not for one minute believe that you've fixed every
problem that will cause, nor do I think "allow wider ACLs" is a
compelling enough reason to take the risk.

I wonder if it'd be practical to move the ACLs for relations
and attributes into some new table, indexed like pg_depend or
pg_description, so that we could dodge that whole problem.
pg_attrdef is a prototype for how this could work.

(Obviously, once we had such a table the ACLs for other things
could be put in it, but I'm not sure that the ensuing breakage
would be justified for other sorts of objects.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-02-28 23:21:54 Overflow of attmissingval is not handled gracefully
Previous Message Andrew Dunstan 2022-02-28 22:59:04 MSVC build system installs extra executables