Re: Introduce ENDLIST to terminate multiline makefile lists

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Introduce ENDLIST to terminate multiline makefile lists
Date: 2025-12-29 03:23:46
Message-ID: 2741126.1766978626@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Dec 29, 2025 at 09:43:30AM +0800, Chao Li wrote:
>> Note that since ENDLIST is defined in Makefile.global.in, this change
>> requires rerunning ./configure.

> FWIW, I don't see an advantage in this proposal, and it has the
> disadvantage of more maintenance if one needs to create a new list.
> The current state of things is simpler.

Same here. This is a new bit of notation that everyone reading our
Makefiles will need to understand, and I don't think it's worth
the extra cognitive burden.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-12-29 03:29:16 Re: Fixing some ancient errors in hash join costing
Previous Message Chao Li 2025-12-29 02:57:14 Re: Introduce ENDLIST to terminate multiline makefile lists