| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: typo fix |
| Date: | 2018-11-20 06:58:22 |
| Message-ID: | 27407.1542697102@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote:
>> - * We also use EquivalenceClasses as the base structure for PathKeys, letting
>> + * We also use EquivalenceClass as the base structure for PathKeys, letting
> ... But not that.
The reason that's not good is that it creates a singular-plural mismatch.
If you'd also changed "PathKeys" to "PathKey", it would still read OK,
though I don't think it's an improvement particularly.
(Hm ... though arguably, "structure" should be "structures" if we're
going to let it stand as plural.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-20 07:15:56 | Re: typo fix |
| Previous Message | Amit Langote | 2018-11-20 06:24:51 | Re: typo fix |