| From: | Konstantin Knizhnik <knizhnik(at)garret(dot)ru> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Orphan page in _bt_split |
| Date: | 2025-09-14 13:40:54 |
| Message-ID: | 273d89f1-d2d6-4732-ad11-b1379a49680f@garret.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13/09/2025 10:10 PM, Peter Geoghegan wrote:
> On Wed, Sep 3, 2025 at 2:25 AM Konstantin Knizhnik<knizhnik(at)garret(dot)ru> wrote:
>> Do you suggest to replace `PageGetTempPage` with using local buffers?
>> Or may be change `PageGetTempPage*` to accept parameter with provided
>> local buffer?
> I think that _bt_split could easily be switched over to using 2 local
> PGAlignedBlock variables, removing its use of PageGetTempPage. I don't
> think that it is necessary to consider other PageGetTempPage callers.
>
Attached please find updated version of the patch which uses
PGAlignedBlock instead of PageGetTempPage.
| Attachment | Content-Type | Size |
|---|---|---|
| v2_bt_split.patch | text/plain | 5.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2025-09-14 13:41:30 | Re: PostgreSQL 18 GA press release draft |
| Previous Message | Nikolay Shaplov | 2025-09-14 08:49:34 | Re: [PATCH] ternary reloption type |