Re: Weird...but correct?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Weird...but correct?
Date: 2004-07-26 14:46:56
Message-ID: 27395.1090853216@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> It's bizarre how you can comment on columns in composite types!
> CREATE TYPE test (a int4, b int4);
> COMMENT ON COLUMN test.a IS 'A column';

And not only that, but:

regression=# \d+ test
Composite type "public.test"
Column | Type | Description
--------+---------+-------------
a | integer | A column
b | integer |

> Seems harmless, but should we allow it?

Why not?

> Shall I fix pg_dump?

Yes please, if it doesn't seem outlandishly hard. (From memory it might
just be adding a subroutine call to dumpType...)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-07-26 14:59:06 Re: Triggers on TRUNCATE?
Previous Message Tom Lane 2004-07-26 14:42:40 Re: storage engine , mysql syntax CREATE TABLE t (i INT)