Re: OK, so culicidae is *still* broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Craig Ringer <craig(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: OK, so culicidae is *still* broken
Date: 2017-05-01 04:53:49
Message-ID: 27354.1493614429@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> Yeah, that's right. Today, I have spent some time to analyze how and
> where retry logic is required. I think there are two places where we
> need this retry logic, one is if we fail to reserve the memory
> (pgwin32_ReserveSharedMemoryRegion) and second is if we fail to
> reattach (PGSharedMemoryReAttach).

I'm not following. The point of the reserve operation is to ensure
that the reattach will work. What makes you think we need to add more
code at that end?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-05-01 05:16:37 Re: snapbuild woes
Previous Message Amit Langote 2017-05-01 04:51:43 Re: Declarative partitioning - another take