Re: pgsql: Fix "base" snapshot handling in logical decoding

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, 2q-andrew(at)alvin(dot)alvh(dot)no-ip(dot)org
Subject: Re: pgsql: Fix "base" snapshot handling in logical decoding
Date: 2018-06-29 23:02:04
Message-ID: 27276.1530313324@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> On 2018-Jun-28, Tom Lane wrote:
>>> According to buildfarm member friarbird, and as confirmed here,
>>> the contrib/test_decoding/specs/oldest_xmin.spec test added by this
>>> commit fails under CLOBBER_CACHE_ALWAYS.

> I suppose 60 seconds (isolationtester's default timeout) is just not
> enough time for those machines. We could increase it to 180 seconds and
> see if that's enough to make them pass ...

What I want to know is why this test is doing a database-wide VACUUM FULL
in the first place. If that isn't profligate wastage of testing cycles,
why not?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-06-30 05:19:49 Re: pgsql: Fix crash when ALTER TABLE recreates indexes on partitions
Previous Message Alvaro Herrera 2018-06-29 22:50:55 Re: pgsql: Fix "base" snapshot handling in logical decoding

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-06-30 05:19:49 Re: pgsql: Fix crash when ALTER TABLE recreates indexes on partitions
Previous Message Alvaro Herrera 2018-06-29 22:50:55 Re: pgsql: Fix "base" snapshot handling in logical decoding