Re: pgbench tap tests & minor fixes

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: pgbench tap tests & minor fixes
Date: 2017-06-25 18:28:16
Message-ID: 27245458.83J8o6YXgQ@x200m
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

В письме от 15 июня 2017 21:10:12 Вы написали:
> > As for me, I would do expr_scanner_chomp_substring(PsqlScanState, int,
> > int&); that changes end_offset as desired...
> Why not.
> > And use it instead of end_offset = expr_scanner_offset(sstate) - 1;
> I removed these?
> > The second issue: you are removing all trailing \n and \r. I think you
> > should remove only one \n at the end of the string, and one \r before \n
> > if there was one.
> So chomp one eol.
> Is the attached version better to your test?

I've expected from expr_scanner_chomp_substring to decrement end_offset, so it
would work more like perl chomp function, but the way you've done is also

The sad think is that in v7 and v8 TAP tests fails. (in v6 it still works, I
have local branches for all your patches versions). I did not check it bdefore
in v7, just read the code. It was my mistake

Do code for fun. Can do it for money (Perl & C/C++ ~10h/week)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2017-06-25 18:28:36 Re: pgbench tap tests & minor fixes
Previous Message Nikolay Shaplov 2017-06-25 18:05:49 Re: [PATCH v.7c] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind for custom AM