Re: Proposal: adding a better description in psql command about large objects

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: "Thibaud W(dot)" <thibaud(dot)walkowiak(at)dalibo(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Proposal: adding a better description in psql command about large objects
Date: 2022-06-03 16:56:20
Message-ID: 272177.1654275380@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Fri, Jun 03, 2022 at 11:12:11AM -0400, Tom Lane wrote:
>> * While we're here, it seems like this whole group was placed at the
>> end because of add-it-to-the-end-itis, not because that was the
>> most logical place for it. The other commands that interact with
>> the server are mostly further up. My first thought is to move it
>> to just after the "Informational" group, but I'm not especially
>> set on that. Making it not-last might make it harder to get away
>> with the inconsistent indentation, though.

> Another option could be to move it after the "Input/Output" section so that
> it's closer to some other commands that involve files. I can't say I have
> a strong opinion about whether/where to move it, though.

Yeah, I thought of that choice too, but it ends up placing the
Large Objects section higher up the list than seems warranted on
frequency-of-use grounds.

After looking at the output I concluded that we'd be better off to
stick with the normal indentation amount, and break the lo_import
entry into two lines to make that work. One reason for this is
that some translators might've already settled on a different
indentation amount in order to cope with translated parameter names,
and deviating from the normal here will just complicate their lives.
So that leaves me proposing v5.

(I also fixed the out-of-date line count in helpVariables.)

regards, tom lane

Attachment Content-Type Size
v5-0001-Add-descriptions-for-psql-s-large-object-backslas.patch text/x-diff 2.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2022-06-03 17:29:11 Re: Proposal: adding a better description in psql command about large objects
Previous Message Daniel Gustafsson 2022-06-03 16:55:28 Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch