| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Mike Fowler <mike(at)mlfowler(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Round Robin Reviewers <pgsql-rrreviewers(at)postgresql(dot)org> |
| Subject: | Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function |
| Date: | 2010-08-08 19:18:17 |
| Message-ID: | 27165.1281295097@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-rrreviewers |
Mike Fowler <mike(at)mlfowler(dot)com> writes:
> On 06/08/10 20:55, Peter Eisentraut wrote:
>> On fre, 2010-08-06 at 09:04 +0100, Mike Fowler wrote:
>>> If the patch is to be committed, does it make sense for me to refine
>>> it such that it uses the new xpath internal function you extracted in
>>> the xmlexists patch?
>>
>> Yes, you can probably shrink this patch down to about 20 lines.
> Updated the patch so that it will apply to head and re-worked the
> function to use the new xpath internal function.
Applied with minor corrections (improved docs, fixed regression tests,
adjusted OIDs for CVS HEAD).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2010-08-08 20:28:34 | Re: knngist - 0.8 |
| Previous Message | Pavel Stehule | 2010-08-08 18:16:45 | Re: Initial review of xslt with no limits patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-08-09 02:29:17 | Re: Patch review: make RAISE without arguments work like Oracle |
| Previous Message | Mike Fowler | 2010-08-07 15:38:06 | Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function |