Re: SSL regression test suite

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SSL regression test suite
Date: 2014-12-04 16:23:58
Message-ID: 27092.1417710238@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> On 10/06/2014 04:21 PM, Heikki Linnakangas wrote:
>> This probably needs some further cleanup before it's ready for
>> committing. One issues is that it creates a temporary cluster that
>> listens for TCP connections on localhost, which isn't safe on a
>> multi-user system.

> This issue remains. There isn't much we can do about it; SSL doesn't
> work over Unix domain sockets. We could make it work, but that's a whole
> different feature.

> How do people feel about including this test suite in the source tree?
> It's probably not suitable for running as part of "make check-world",
> but it's extremely handy if you're working on a patch related to SSL.
> I'd like to commit this, even if it has some rough edges. That way we
> can improve it later, rather than have it fall into oblivion. Any
> objections?

As long as it's not run by any standard target, and there's some
documentation explaining why not, I see no reason it can't be in the
tree.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2014-12-04 16:33:27 Re: Sequence Access Method WIP
Previous Message David Fetter 2014-12-04 16:13:21 Re: SSL regression test suite