Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path on environment
Date: 2004-07-12 19:45:44
Message-ID: 27086.1089661544@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> You're not doing very well with this project :-(. pg_ctl is now
>> actively broken, because the PGDATA value passed down to the
>> bootstrap backend is the one in the environment variable. The
>> previous coding canonicalized that, this does not.

> I didn't think we could modify the environment variables like that
> portably.

Possibly not, but if you think that then the correct response is to
re-assign the environment var using putenv().

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2004-07-12 19:54:30 Re: pgsql-server: Use strdup in pg_ctl for canonicalize_path
Previous Message Bruce Momjian 2004-07-12 19:27:33 pgsql-server: Add blank line to new canonicalize_path file, which