From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
Date: | 2008-11-28 16:56:35 |
Message-ID: | 27059.1227891395@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> See attached patch which takes out the parts of fnmatch that we're not
> interested in, and puts it directly in fe-secure.c. Obviously, if we go
> down that way, we can remove fnmatch.c from port again :-)
> Thoughts?
Generally +1, but a couple of comments:
* This seems to be still mostly NetBSD code, so I think you need to do
more than just credit them in an aside. Should we repeat the full
NetBSD copyright notice for this one function?
* This is still making unjustified assumptions about the behavior of
tolower/toupper. I think you probably want ASCII-only case folding,
ie use pg_toupper/pg_tolower. If it actually should be locale aware
then it's still wrong because it won't work in multibyte encodings.
Also you forgot the de rigueur (unsigned char) casts for ctype.h calls.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-11-28 18:04:01 | pgsql: Cosmetic cleanups in contrib/isn (doesn't fix the passbyval |
Previous Message | Magnus Hagander | 2008-11-28 15:13:54 | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2008-11-28 16:59:12 | Re: Server Crash into contrib module ISN into 64bit OS |
Previous Message | Tom Lane | 2008-11-28 16:49:17 | Re: Distinct types |