| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | James Coleman <jtc331(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Teach predtest about IS [NOT] <boolean> proofs |
| Date: | 2024-03-25 21:53:06 |
| Message-ID: | 2703176.1711403586@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
James Coleman <jtc331(at)gmail(dot)com> writes:
> [ v6 patchset ]
I went ahead and committed 0001 after one more round of review
statements; my bad). I also added the changes in test_predtest.c from
0002. I attach a rebased version of 0002, as well as 0003 which isn't
changed, mainly to keep the cfbot happy.
I'm still not happy with what you did in predicate_refuted_by_recurse:
it feels wrong and rather expensively so. There has to be a better
way. Maybe strong vs. weak isn't quite the right formulation for
refutation tests?
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0002-Teach-predtest.c-about-BooleanTest.patch | text/x-diff | 48.3 KB |
| v6-0003-Add-temporary-all-permutations-test.patch | text/x-diff | 32.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | walther | 2024-03-25 21:58:30 | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Previous Message | Tom Lane | 2024-03-25 21:44:08 | Re: Add bump memory context type and use it for tuplesorts |