Re: Exit walsender before confirming remote flush in logical replication

From: Andrey Silitskiy <a(dot)silitskiy(at)postgrespro(dot)ru>
To: Ronan Dunklau <ronan(at)dunklau(dot)fr>
Cc: Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "sawada(dot)mshk(at)gmail(dot)com" <sawada(dot)mshk(at)gmail(dot)com>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>, "peter(dot)eisentraut(at)enterprisedb(dot)com" <peter(dot)eisentraut(at)enterprisedb(dot)com>, "dilipbalaut(at)gmail(dot)com" <dilipbalaut(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: Exit walsender before confirming remote flush in logical replication
Date: 2026-01-28 11:33:31
Message-ID: 26b41b30-2484-4fa7-b951-b97805101bd7@postgrespro.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Ronan,
Thanks for participating in the discussion.

On Jan 28, 2026 Ronan Dunklau <ronan(at)dunklau(dot)fr> wrote:
> ... a timeout for the wait (maybe named wal_sender_stop_timeout ?) would
> allow for the same usage ...

Sounds like an option.
This is also possible in the current implementation, but your option offers
a simpler interface if we do not plan to add new wallsender completion
modes.
The naming of the parameter is also a question, because wal_sender_timeout
already exists (which also fits the name wal_sender_stop_timeout quite
well).
The difference between these parameters may not be obvious to users.
Thoughts?

Regards,
Andrey Silitskiy

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-01-28 12:03:48 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Andrey Silitskiy 2026-01-28 11:27:14 Re: Exit walsender before confirming remote flush in logical replication