Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: 2019-06-14 13:11:15
Message-ID: 26948.1560517875@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Christoph Berg <myon(at)debian(dot)org> writes:
> Re: Tom Lane 2019-06-11 <24452(dot)1560285699(at)sss(dot)pgh(dot)pa(dot)us>
>> The only way I can get it to pick "Etc/UCT" is if that's what I put
>> into /etc/localtime. (In which case I maintain that that's not a bug,
>> or at least not our bug.)

> Did you try a symlink or a plain file for /etc/localtime?

Symlink --- if it's a plain file, our code can't learn anything from it.

> On Debian unstable, deleting /etc/timezone, $TZ not set, and with this symlink:
> lrwxrwxrwx 1 root root 27 Mär 28 14:49 /etc/localtime -> /usr/share/zoneinfo/Etc/UTC

> /usr/lib/postgresql/11/bin/initdb -D pgdata
> $ grep timezone pgdata/postgresql.conf
> log_timezone = 'UCT'
> timezone = 'UCT'

> /usr/lib/postgresql/12/bin/initdb -D pgdata
> $ grep timezone pgdata/postgresql.conf
> log_timezone = 'Etc/UTC'
> timezone = 'Etc/UTC'

That's what I'd expect. Do you think your upthread report of HEAD
picking "Etc/UCT" was a typo? Or maybe you actually had /etc/localtime
set that way?

>> Anyway, moving on to the question of what should we do about this,
>> I don't really have anything better to offer than back-patching 23bd3cec6.

> The PG12 behavior seems sane, so +1.

OK, I'll make that happen.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2019-06-14 13:30:35 pgsql: doc: PG 12 relnotes, add mention of single-child optimization
Previous Message Etsuro Fujita 2019-06-14 11:53:54 pgsql: postgres_fdw: Fix costing of pre-sorted foreign paths with local

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2019-06-14 13:30:41 Re: PostgreSQL 12: Feature Highlights
Previous Message Bruce Momjian 2019-06-14 13:02:13 Re: "WIP: Data at rest encryption" patch and, PostgreSQL 11-beta3