| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove utils/acl.h from catalog/objectaddress.h |
| Date: | 2020-03-08 18:28:57 |
| Message-ID: | 26906.1583692137@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> I noticed that catalog/objectaddress.h includes utils/acl.h for no
> apparent reason. It turns out this used to be needed but not anymore.
> So removed it and cleaned up the fallout. Patch attached.
Seems reasonable. One thing I noticed is that if you are including
nodes/parsenodes.h explicitly in objectaddress.h, there seems little
point in the #include "nodes/pg_list.h" right beside it.
Sometime we really ought to make an effort to make our header inclusions
less of a mass of spaghetti. But this patch needn't take on that load.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2020-03-08 18:34:06 | Re: Use compiler intrinsics for bit ops in hash |
| Previous Message | Tom Lane | 2020-03-08 18:19:46 | Re: Allow to_date() and to_timestamp() to accept localized names |