Re: Debug in dest.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Debug in dest.h
Date: 2005-11-01 18:14:39
Message-ID: 26822.1130868879@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> The "Debug" destreceiver has a pretty bad name. In fact for PL/php it
> collides with a PHP symbol. Does anyone mind if I rename it to, say,
> DestDebug?

If you do that, you should rename all the values of the enum
(DestNone, etc). For consistency, and because the same charge
could be leveled at None and Remote.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim C. Nasby 2005-11-01 18:17:42 Re: Ideas for easier debugging of backend problems
Previous Message Marc G. Fournier 2005-11-01 17:45:09 Re: FreeBSD broke with autoconf-based build

Browse pgsql-patches by date

  From Date Subject
Next Message Jim C. Nasby 2005-11-01 18:49:08 Re: slru.c race condition (was Re: TRAP: FailedAssertion("!((itemid)->lp_flags & 0x01)", )
Previous Message Alvaro Herrera 2005-11-01 17:40:20 Debug in dest.h