Fixing AC_CHECK_DECLS to do the right thing with clang

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Noah Misch <noah(at)leadboat(dot)com>
Subject: Fixing AC_CHECK_DECLS to do the right thing with clang
Date: 2018-11-18 04:32:47
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

We've seen repeated complaints about bogus build warnings when using
"clang": it complains that strlcpy and some related library functions
haven't been declared. Several of the buildfarm animals exhibit such
warnings, for instance. That's because Autoconf's AC_CHECK_DECLS macro
fails to cope with the fact that clang only generates a warning, not
an error, for the test case that that macro uses. Noah fixed this
in upstream autoconf several years ago:

However, I'm beginning to despair of the Autoconf crowd ever putting
out an official new release. Hence, I propose to apply and back-patch
the attached, which essentially just imports Noah's fix into our
configure script. I've verified that this does the right thing with
Fedora 28's version of clang (clang version 6.0.1).

regards, tom lane

Attachment Content-Type Size
import-autoconf-fix-for-clang.patch text/x-diff 10.5 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2018-11-18 07:30:31 Re: make installcheck-world in a clean environment
Previous Message Alvaro Herrera 2018-11-18 02:20:50 Re: Psql patch to show access methods info