| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, "damien(at)dalibo(dot)info" <damien(at)dalibo(dot)info>, Greg Sabino Mullane <greg(at)turnstep(dot)com> |
| Subject: | Re: Have \d show child tables that inherit from the specified parent |
| Date: | 2009-07-07 19:35:52 |
| Message-ID: | 26800.1246995352@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On Tuesday 07 July 2009 19:35:54 Tom Lane wrote:
>> I looked at this patch. I'm a bit disturbed by the
>> ORDER BY c.oid::pg_catalog.regclass
>> business. I doubt that does what the author thinks, and I'm not sure
>> what we really want anyway. If we want the child table names sorted
>> alphabetically then the regclass value needs to be further cast to text,
>> ie
>> ORDER BY c.oid::pg_catalog.regclass::pg_catalog.text
> Fixed; it was clearly meant to be by name.
Testing shows that we still have a problem: the query now fails outright
with pre-8.3 servers:
regression=# \d+ a
ERROR: cannot cast type regclass to text
Perhaps it would be sufficient to ORDER BY c.relname.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-07 19:42:00 | Re: [HACKERS] commitfest.postgresql.org |
| Previous Message | Dimitri Fontaine | 2009-07-07 19:33:54 | Re: *_collapse_limit, geqo_threshold |