Re: Making server name part of the startup message

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Satyanarayana Narlapuram <Satyanarayana(dot)Narlapuram(at)microsoft(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Making server name part of the startup message
Date: 2017-06-21 20:13:41
Message-ID: 26771.1498076021@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Satyanarayana Narlapuram <Satyanarayana(dot)Narlapuram(at)microsoft(dot)com> writes:
>> Why do we need to incur a protocol break to add another one?

> This is optional and is not a protocol break.

Yes, it is. We've been around on this sort of thing before and we
understand the consequences. If the option is carried in the startup
message, the client has to send it without knowing whether the server
is of new enough version to accept it. If not, the server will reject
the connection (with a scary looking message in its log) and the client
then has to retry without the option. This is not distinguishable from
what you have to do if you consider the startup message as belonging
to a new protocol version 4 instead of 3.

We have done this in the past, but it's painful, subject to bugs,
and generally is a pretty high price to pay for a marginal feature.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-06-21 20:27:42 Re: UPDATE of partition key
Previous Message Robert Haas 2017-06-21 20:11:01 Re: UPDATE of partition key