| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Issue with NULLS LAST, with postgres_fdw sort pushdown |
| Date: | 2016-03-03 05:08:56 |
| Message-ID: | 26733.1456981736@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> writes:
> On Thu, Mar 3, 2016 at 7:27 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>> Per explain.c, this looks inconsistent to me. Shouldn't NULLS LAST be
>> applied only if DESC is used in this ORDER BY clause?
> ... In this case we are constructing a query to be
> sent to the foreign server and it's better not to leave the defaults to be
> interpreted by the foreign server; in case it interprets them in different
> fashion. get_rule_orderby() also explicitly adds these options.
Yeah, I agree that we don't need to go out of our way to make the query
succinct here. Explicitness is easier and safer too, so why not?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2016-03-03 05:16:31 | Re: pg_hba_lookup function to get all matching pg_hba.conf entries |
| Previous Message | Craig Ringer | 2016-03-03 05:08:47 | Re: Dockerfile for testing with Perl 5.8.8 |