| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: assume availability of "inline" keyword |
| Date: | 2026-02-19 19:19:33 |
| Message-ID: | 2670103.1771528773@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> I noticed some code that uses __inline__ (which IIUC is a gcc extension) as
> well as a related configure check. "inline" was first added to C99, and we
> now require C11, so we can just assume it's there, right? FWIW it looks
> like meson builds don't bother checking this.
All those usages are guarded by
#if defined(__GNUC__) || defined(__INTEL_COMPILER)
so we are only concerned with gcc-alikes, which reduces the risks
of trouble. However, I have a vague recollection that it is/was
possible to put gcc in a mode where it only takes __inline__
not inline. This is likely something you get from -std=c90 or
thereabouts, which would be irrelevant now. But I'd suggest
checking it's okay under -std=c11 (not gnu11), just to be sure.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-02-19 19:28:58 | Re: Hash aggregate collisions cause excessive spilling |
| Previous Message | Andres Freund | 2026-02-19 19:01:15 | Re: Hash aggregate collisions cause excessive spilling |