Re: pgsql-server: Add some strings for translation and remove some

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dennis Bjorklund <db(at)zigo(dot)dhs(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Add some strings for translation and remove some
Date: 2004-08-04 16:38:01
Message-ID: 2670.1091637481@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

dennis(at)svr1(dot)postgresql(dot)org (Dennis Bjorklund) writes:
> Add some strings for translation and remove some cut'n'paste
> that makes it impossible to translate to other languages.

The way you've done this, the string will be passed through gettext
twice at runtime (once in this routine, once inside errmsg()). That's
at best a waste of cycles and at worst a wrong answer. (Though
a match on the translated string isn't likely, it's not impossible.)

You should use gettext_noop() not gettext() to mark these strings as
translatable.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Dennis Bjorklund 2004-08-04 16:40:12 pgsql-server: Translation updates
Previous Message Tom Lane 2004-08-04 16:25:04 pgsql-server: Make use of backup label/history files to control recovery