Skip site navigation (1) Skip section navigation (2)

Re: logical changeset generation v4

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: logical changeset generation v4
Date: 2013-01-15 16:10:22
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> But the other part of the problem is hiding in the unfortunately removed
> part of the problem description - the tests require the non-default
> options wal_level=logical and max_logical_slots=3+.

Oh.  Well, that's not going to work.

> Is there a problem of making those the default in the buildfarm created
> config?

Even if we hacked the buildfarm script to do so, it'd be a nonstarter
because it would cause ordinary manual "make installcheck" to fail.

I think the only reasonable way to handle this would be to (1) make
"make installcheck" a no-op in this contrib module, and (2) make
"make check" work, being careful to start the test postmaster with
the necessary options.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Tom LaneDate: 2013-01-15 16:19:28
Subject: Re: Curious buildfarm failures
Previous:From: Stephen FrostDate: 2013-01-15 16:08:45

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group