From: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [HACKERS] psql commandline conninfo |
Date: | 2006-12-16 13:11:09 |
Message-ID: | 2663.24.211.165.134.1166274669.squirrel@www.dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> "Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:
>> Here's the patch for what I think is the consensus position. If there's
>> no
>> objection I will apply this and document it.
>
> Please do something for the comment for the connectOptions1 call.
> As you've coded it, that is doing two completely different things
> and the comment is almost completely unhelpful at explaining this
> complexity. Oh, and casting away const gets no points for style.
ouch. :-)
Ok, I accept the reproof. In fact I got up this morning, had my coffee,
and thought "That's a silly way to do it, I could make it much neater by
moving the dbName processing up," and lo and behold when I read your email
you had done it :-) It shall be done as you wish.
BTW, what is the approved way to handle warnings about const? Copy the
object?
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | ohp | 2006-12-16 15:00:13 | Re: unixware and --with-ldap |
Previous Message | Joachim Wieland | 2006-12-16 10:57:32 | Re: invalid input syntax for type timestamp. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-12-16 15:38:40 | Re: [HACKERS] psql commandline conninfo |
Previous Message | Tom Lane | 2006-12-16 04:55:04 | Re: [HACKERS] psql commandline conninfo |