Re: Generate pg_stat_get_* functions with Macros

Hi,

On 12/3/22 9:16 PM, Nathan Bossart wrote:
> On Sat, Dec 03, 2022 at 10:31:19AM +0100, Drouvot, Bertrand wrote:
>> On 12/3/22 1:51 AM, Nathan Bossart wrote:
>>> Can we hard-code the prefix in the macro? It looks like all of these use
>>> the same one.
>>
>> Good point! Done in V2 attached.
>
> Thanks. I editorialized a bit in the attached v3. I'm not sure that my
> proposed names for the macros are actually an improvement. WDYT?
>

Thanks! I do prefer the macros definition ordering that you're proposing (that makes pgstatfuncs.c "easier" to read).

As far the names, I think it's better to replace "TAB" with "REL" (like in v4 attached): the reason is that those macros will be used in [1] for both tables and indexes stats (and so we'd have to replace "TAB" with "REL" in [1]).
Having "REL" already in place reduces the changes that will be needed in [1].

[1]: https://www.postgresql.org/message-id/flat/f572abe7-a1bb-e13b-48c7-2ca150546822(at)gmail(dot)com

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com