Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Pg Committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()
Date: 2018-12-21 16:00:37
Message-ID: 26516.1545408037@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Hmmm, I'm fairly sure you should have bumped XLOG_PAGE_MAGIC for this
> change. Otherwise, what is going to happen to an unpatched standby (of
> released versions) that receives the new WAL record from a patched
> primary?

We can't change XLOG_PAGE_MAGIC in released branches, surely.

I think the correct thing is just for the release notes to warn people
to upgrade standby servers first.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-12-21 16:09:32 Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()
Previous Message Alvaro Herrera 2018-12-21 15:49:14 Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-12-21 16:09:32 Re: pgsql: Check for conflicting queries during replay of gistvacuumpage()
Previous Message Tom Lane 2018-12-21 15:57:22 Re: Changes to pg_dump/psql following collation "C" in the catalog