Re: Test instability when pg_dump orders by OID

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Aug 10, 2025 at 12:37 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
>> Thanks. Given the current state of freeze for tomorrow's release wrap, the
>> decision is less obvious than usual. I'm seeing these options:
>>
>> 1. Remove the new assertion in v13-v18.
>> 2. Push your proposed fix.
>> 3. Change nothing. (This would be the choice if one is maximally concerned
>> about deviating from the freeze and unconcerned about --enable-cassert
>> builds of releases.)
>>
>> I am inclined to make today's change be (1).

> Sounds right to me.

I agree. The fact that this case escaped notice suggests that there
might be more. We don't want to ship a version of pg_dump that will
assert if that happens. Keep the assert in HEAD, for sure, but it's
uncomfortable having it in back branches.

As for the actual fix, push it after the freeze lifts. The fact that
we didn't quite get there on making dump order stable isn't a
freeze-break-worthy bug.

regards, tom lane