| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: new compiler warnings |
| Date: | 2011-01-26 21:50:24 |
| Message-ID: | 26492.1296078624@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On ons, 2011-01-26 at 06:33 -0500, Robert Haas wrote:
>> I recently started getting these:
>>
>> plpython.c: In function PLy_output:
>> plpython.c:3468: warning: format not a string literal and no format arguments
>> plpython.c: In function PLy_elog:
>> plpython.c:3620: warning: format not a string literal and no format arguments
>> plpython.c:3627: warning: format not a string literal and no format arguments
>>
>> Please fix.
> Which version of which compiler is showing this?
I've been seeing that for some time with gcc 2.95.3, so it's not exactly
a new issue. I've not seen it with modern versions, but I'm not sure
why not. What it's unhappy about is the "errhint(hint)" calls, which
I agree with it are dangerous on their face. Maybe you're 100% sure the
hint strings will never contain percent marks, but I'm not.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-01-26 21:55:56 | Re: [HACKERS] Seeking Mentors for Funded Reviewers |
| Previous Message | David Fetter | 2011-01-26 21:50:21 | Re: [HACKERS] Seeking Mentors for Funded Reviewers |