Re: [RRR] Tests citext casts

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
Cc: Kenneth Marshall <ktm(at)rice(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [RRR] Tests citext casts
Date: 2008-11-07 23:18:45
Message-ID: 26484.1226099925@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

"David E. Wheeler" <david(at)kineticode(dot)com> writes:
> On Nov 7, 2008, at 11:15 AM, Tom Lane wrote:
>> My inclination is to remove the XML-dependent citext tests, which don't
>> seem especially useful, and then we can have whatever variants we need
>> for locales. citext locale behavior seems much more interesting than
>> testing whether it casts to xml or not.

> Agreed, but I admit to being mystified as to why things would be
> sorting any differently on darwin vs. Fedora. I kept everything in
> ASCII, on your advice, to keep from having to deal with crap like this.

Patch applied with this adjustment.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Emmanuel Cecchet 2008-11-07 23:19:48 Re: Transactions and temp tables
Previous Message Alvaro Herrera 2008-11-07 23:14:04 Re: Updated backslash consistency patch

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message David E. Wheeler 2008-11-07 23:33:43 Re: [RRR] Tests citext casts
Previous Message Josh Berkus 2008-11-07 22:03:43 Does anyone do WIndows?