Re: errbacktrace

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: errbacktrace
Date: 2019-11-23 16:11:08
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2019-Oct-26, Peter Eisentraut wrote:
>> I hadn't realized that you had already attached a patch that implements
>> your idea. It looks good to me. Maybe a small comment near
>> check_backtrace_functions() why we're not using a regular list. Other
>> than that, please go ahead with this.

> Thanks, I added that comment and others, and pushed. Let's see what
> happens now ...

I had occasion to try to use errbacktrace() just now, and it blew up
on me. Investigation finds this:

ErrorData *edata = &errordata[errordata_stack_depth];
MemoryContext oldcontext;


I suppose that's a debugging leftover that shouldn't have been committed?
It did what I wanted after I took out the Assert.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-11-23 16:14:06 Re: errbacktrace
Previous Message Tom Lane 2019-11-23 16:07:18 Re: Assertion failing in master, predicate.c