Re: errbacktrace

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> On 2019-Oct-26, Peter Eisentraut wrote:
>> I hadn't realized that you had already attached a patch that implements
>> your idea. It looks good to me. Maybe a small comment near
>> check_backtrace_functions() why we're not using a regular list. Other
>> than that, please go ahead with this.

> Thanks, I added that comment and others, and pushed. Let's see what
> happens now ...

I had occasion to try to use errbacktrace() just now, and it blew up
on me. Investigation finds this:

int
errbacktrace(void)
{
ErrorData *edata = &errordata[errordata_stack_depth];
MemoryContext oldcontext;

Assert(false);

I suppose that's a debugging leftover that shouldn't have been committed?
It did what I wanted after I took out the Assert.

regards, tom lane