Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
Date: 2008-04-21 03:52:21
Message-ID: 26453.1208749941@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a stopgap
>> measure to get the Windows buildfarm members working again. I don't
>> know if it's worth exposing these as configurables, or exactly how to
>> do it in the MSVC build system ...

> see src/tools/msvc/Solution.pm

> The options are picked up from config.pl (which is the equivalent of
> configure invocation options) in the new() subroutine, and the config
> files are written accordingly in the GenerateFiles() subroutine.

> In general I'm in favor of keeping these as closely aligned as possible.

Go for it --- I'm not excited about adding stuff to platform-specific
code that I can't test.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Dave Page 2008-04-21 06:35:02 Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
Previous Message Tom Lane 2008-04-21 03:49:51 pgsql: Fix a couple of places in execMain that erroneously assumed that