Re: pgsql-server/src/backend/utils/adt numeric.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server/src/backend/utils/adt numeric.c
Date: 2003-07-03 21:13:30
Message-ID: 2642.1057266810@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
>> Fix bug I introduced in recent rewrite of NUMERIC code: numeric to
>> integer conversions gave the wrong answer for values with stripped
>> trailing zeroes, such as 10000000.

> No regression test?

Don't see the point --- it's a one-off fix. (Wrong loop termination
condition in one place.) I put in regression tests for things that
I think might break again in future, or if I can see a way to test for
a whole class of errors rather than one single routine.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2003-07-04 02:51:34 pgsql-server/src backend/catalog/aclchk.c back ...
Previous Message Alvaro Herrera 2003-07-03 20:51:57 Re: pgsql-server/src/backend/utils/adt numeric.c