| From: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Push down time-related SQLValue functions to foreign server |
| Date: | 2021-08-20 12:18:09 |
| Message-ID: | 2641ccef46e433bf088edc3f8569be6b@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Ranier Vilela писал 2021-08-20 14:19:
> Another question:
> For 0002 patch:
>
> + if (node->funcid == F_NOW)
> + {
> + SQLValueFunction *svf = makeNode(SQLValueFunction);
> +
> + svf->op = SVFOP_CURRENT_TIMESTAMP;
> + svf->type = TIMESTAMPTZOID;
> + svf->typmod = -1;
> + svf->location = -1;
> +
> + deparseSQLValueFunction(svf, context);
> +
> + return;
> + }
> It seems to me that the svf->xpr field ( SQLValueFunction *svf ) is
> not initialized somewhere even by deparseSQLValueFunction.
> If it's not really used, it should be initialized to NULL, ok?
>
xpr field just carries node type, which will be initialized by
makeNode().
--
Best regards,
Alexander Pyhalov,
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-08-20 12:55:13 | Re: Autovacuum on partitioned table (autoanalyze) |
| Previous Message | Matthias van de Meent | 2021-08-20 11:54:42 | Re: NAMEDATALEN increase because of non-latin languages |