| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Bernd Helmle <mailings(at)oopsware(dot)de>, Mathis Rudolf <mathis(dot)rudolf(at)credativ(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Alias collision in `refresh materialized view concurrently` |
| Date: | 2021-08-07 02:35:40 |
| Message-ID: | 2638253.1628303740@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Fri, Aug 06, 2021 at 10:48:40AM -0400, Tom Lane wrote:
>> Given that it took this long to notice the problem at all, maybe
>> this is not a fix to cram in on the weekend before the release wrap.
>> But I don't see why we need to settle for "mostly works" when
>> "always works" is barely any harder.
> Yes, I would vote to delay that for a couple of days. That's not
> worth taking a risk for.
I went ahead and created the patch, including test case, and it
seems fine. So I'm leaning towards pushing that tomorrow. Mainly
because I don't want to have to document "we partially fixed this"
in this release set and then "we really fixed it" three months from
now.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-08-07 02:44:07 | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |
| Previous Message | Andres Freund | 2021-08-07 02:30:26 | pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |