Re: Portability issues in shm_mq

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Portability issues in shm_mq
Date: 2014-03-18 20:14:38
Message-ID: 26354.1395173678@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Mar 18, 2014 at 12:15 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Meh. I think you're putting a bit too much faith in your ability to
>> predict the locus of bugs that you think aren't there.

> Well, I'm open to suggestions.

As a suggestion: it'd be worth explicitly testing zero-byte and one-byte
messages, those being obvious edge cases. Then, say, randomly chosen
lengths in the range 100-1000; this would help ferret out odd-length
issues. And something with message sizes larger than the queue size.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua Yanovski 2014-03-18 20:18:24 Re: [WIP] Better partial index-only scans
Previous Message Josh Berkus 2014-03-18 20:11:26 Re: First-draft release notes for next week's releases