| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A few warnings on Windows |
| Date: | 2018-05-02 20:01:53 |
| Message-ID: | 26334.1525291313@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> The only remaining warnings on those machines now come from the fact
> that our port_win32.h and Perl's XSUB.h both want to define macros to
> define macros for libc functions like mkdir etc. plperl.h already
> seems to deal with other similar kinds of ugliness. Perhaps if
> PG_NEED_PERL_XSUB_H is defined we should undefine port_win32.h's
> libc-stealing macros before including it? Either way XSUB.h's
> definitions win. That should get us to 0 warnings. See attached (not
> tested).
Seems reasonable to me. Pushed, we'll see what the buildfarm thinks.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-05-02 20:55:33 | Re: Is there a memory leak in commit 8561e48? |
| Previous Message | Tom Lane | 2018-05-02 19:21:49 | Unportable code in autoprewarm.c |