From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Rod Taylor" <rbt(at)zort(dot)ca> |
Cc: | "Neil Conway" <nconway(at)klamath(dot)dyndns(dot)org>, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL Patches" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Basic DOMAIN Support |
Date: | 2002-03-08 02:42:36 |
Message-ID: | 26312.1015555356@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
"Rod Taylor" <rbt(at)zort(dot)ca> writes:
> Anyway, I copped out and added a %expect 1.
Sorry, but we agreed long ago that %expect is *not* an acceptable
alternative to getting the bugs out of your yacc productions.
%expect is okay for stable grammars or ones that are being hacked by
just one or two closely-involved people. The PG grammar is being hit on
all the time by a lot of people with varying yacc skill, and some of the
rearrangements are not trivial. The problem with %expect for us is: all
right, we just ignored N shift/reduce errors --- but are they the same N
errors that someone once long ago decided were okay? It's too risky.
I believe your real problem has nothing to do with the c_expr anyway,
but is that DEFAULT is an allowable ColLabel. I do not recall which
keywords we currently need to accept as def_elem labels, but perhaps
it'd work to back off the lefthand side from ColLabel to ColId or
some such.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Christopher Kings-Lynne | 2002-03-08 02:56:20 | Re: Basic DOMAIN Support |
Previous Message | Rod Taylor | 2002-03-08 01:40:04 | Re: Basic DOMAIN Support |